Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating definitions/syns, and multiple labels are present, dosdp tools create weird values. #412

Closed
matentzn opened this issue May 7, 2022 · 4 comments · Fixed by #414
Labels

Comments

@matentzn
Copy link

matentzn commented May 7, 2022

When the source ontology, say foodon, contains terms with more than one label (shrimp, "shrimp as a food source"), dosdp tools generate bad looking definitions:

An exposure to shrimp as food sourceshrimp via ingestion.

and synonyms:

shrimp as food sourceshrimp exposure via ingestion
@matentzn
Copy link
Author

matentzn commented May 7, 2022

Also, if there are multiple labels, the choice of which label to use should be deterministic. Not sure this is the case.

@balhoff
Copy link
Member

balhoff commented May 10, 2022

@matentzn is this in generate?

@matentzn
Copy link
Author

Yes, generate! See ECTO Makefile just usual dosdp generate step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants