1.0.2 support. Python 3 endode / decode problems fixed #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheemreddy181-zz
approved these changes
Jan 27, 2021
|
Tested - this works for me. Let's get it merged. |
bheemreddy181-zz
approved these changes
Apr 16, 2021
|
Actually just found an issue:
The issue is with The fix: content_type = r.headers.get('content-type')
if not content_type:
content_type = b''If we remove the |
costi
suggested changes
Apr 16, 2021
| path = url.path | ||
| if url.query: | ||
| path = path + '?' + url.query | ||
|
|
||
| string_to_sign = '%s,%s,%s,%s,%s' % (method, content_type, content_md5, path, httpdate) | ||
| digest = hmac.new(self.secret_key, string_to_sign, hashlib.sha1).digest() | ||
| string_to_sign = '%s,%s,%s,%s,%s' % (method, content_type.decode(), content_md5, path, httpdate) |
There was a problem hiding this comment.
We need to take care the empty content-type case.
if not content_type:
content_type = ''
Error:
http: error: AttributeError: 'str' object has no attribute 'decode'
Change line 23 to content_type = b''
|
After fixing it let's release it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets people use Python3, and newer versions of httpie. maybe.