Rule methodsShouldNotThrowGenericException should check for Exception…

… and RuntimeException
enofex · Jun 11, 2024 · 7bdf0ac · 7bdf0ac
1 parent 9c800e1
commit 7bdf0ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/USERGUIDE.md b/docs/USERGUIDE.md
@@ -62,7 +62,7 @@ Taikai.builder()
     .check();
 ```
 
-- **Methods Should Not Throw Generic Exception**: Ensure that methods do not throw generic exceptions and use specific exception types instead.
+- **Methods Should Not Throw Generic Exception**: Ensure that methods do not throw generic exceptions like `Exception` and `RuntimeException` and use specific exception types instead.
 
 ```java
 Taikai.builder()

diff --git a/src/main/java/com/enofex/taikai/java/JavaConfigurer.java b/src/main/java/com/enofex/taikai/java/JavaConfigurer.java
@@ -46,7 +46,8 @@ public JavaConfigurer methodsShouldNotThrowGenericException() {
   public JavaConfigurer methodsShouldNotThrowGenericException(Configuration configuration) {
     return addRule(TaikaiRule.of(methods()
         .should().notDeclareThrowableOfType(Exception.class)
-        .as("Methods should not throw generic Exception"), configuration));
+        .orShould().notDeclareThrowableOfType(RuntimeException.class)
+        .as("Methods should not throw generic Exception or RuntimeException"), configuration));
   }
 
   public JavaConfigurer noUsageOfDeprecatedAPIs() {