Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra records when merging different TimeseriesData instances. #46

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

cipherself
Copy link
Contributor

@cipherself cipherself commented Aug 5, 2024

This PR handles the situation when attempting to merge timeseries records of different chunks where a later chunk has extra records.

Copy link

github-actions bot commented Aug 5, 2024

Coverage results

Update on 2024-08-06 08:45:52.984491181 +0000

This is the coverage report for commit d4c3835

Name                                                                                Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/__init__.py                                 4      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/base.py                        70      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/client.py      20      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/production_runs/models.py      52      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/client.py           19      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/api_clients/timeseries/models.py           44      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/auth.py                                    13      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/client.py                                 108      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/constants.py                                8      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/errors.py                                   3      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/iterable_tools.py                           7      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/models.py                                 110      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/schema.py                                  26      0   100%
.tox/py/lib/python3.12/site-packages/enlyze/validators.py                              38      0   100%
-----------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 522      0   100%

4 empty files skipped.

@cipherself cipherself force-pushed the minor/data-disparity-merge-error branch from 61e6476 to d4c3835 Compare August 6, 2024 08:41
@cipherself cipherself self-assigned this Aug 6, 2024
@cipherself cipherself marked this pull request as ready for review August 6, 2024 09:42
@cipherself cipherself requested a review from denizs August 6, 2024 09:42
@cipherself cipherself merged commit d1d393c into master Aug 6, 2024
9 checks passed
@cipherself cipherself deleted the minor/data-disparity-merge-error branch August 6, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants