Expose production runs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was causing spell and link checks to fail
☝️ This PR is the first in a row in an effort to expose production runs via the ENLYZE SDK. At the moment, we only expose time series data via the SDK and interaction with the timeseries service is contained in the `TimeseriesApiClient`. However, the new production runs API introduces a different pagination pattern, which makes it inconvenient to generalize the `TimeseriesApiClient` to a `EnlyzePlatformApiClient` ™️. Thus, this and subsequent PRs are building on top of the assumption that we will have separate API Clients for the timeseries and production runs API. This first PR introduces an `ApiBaseClient` class, which implement generalized `get` and `get_paginated` methods. The latter calls two abstract methods, `_has_more` and `_next_page_call_args` that must be implemented by API clients deriving from this class. --------- Co-authored-by: Daniel Krebs <[email protected]>
Building up on #14 , this PR introduces the `ProductionRunsApiClient`, which instruments the Production Runs API. A subsequent PR will then expose a `ProductionRun` user model via the `EnlyzeClient`. --------- Co-authored-by: Daniel Krebs <[email protected]>
) Co-authored-by: Deniz Saner <[email protected]> Co-authored-by: Deniz Saner <[email protected]>
This PR exposes production runs via the `EnlyzeClient`. I would suggest reviewing this PR commit by commit. --------- Co-authored-by: Mohamed Attia <[email protected]> Co-authored-by: Daniel Krebs <[email protected]>
Coverage resultsUpdate on 2023-10-17 15:12:39.846543633 +0000 This is the coverage report for commit c184a57 |
daniel-k
requested changes
Oct 17, 2023
daniel-k
requested changes
Oct 17, 2023
Co-authored-by: Daniel Krebs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes production runs via the
EnlyzeClient.The heavy lifting has been performed in
ApiBaseClientand deriveTimeseriesApiClientfrom it #14ProductionRunsApiClient#15