Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger dependency to fix warning on Ruby 3.4 #199

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

mattbrictson
Copy link
Contributor

When using childprocess on Ruby 3.4.0.dev, the following warning is printed:

lib/childprocess.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.

This PR fixes the warning by adding the logger gem as a gemspec dependency.

I chose ~> 1.5 as the requirement because 1.5.0 is the most recent version that supports Ruby 2.4.

I also added Ruby head to the CI matrix.

Fixes the following warning:

> lib/childprocess.rb:7: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.
@mattbrictson
Copy link
Contributor Author

The CI failures are hopefully temporary, due to a broken release of the term-ansicolor gem: flori/term-ansicolor#41

@mattbrictson mattbrictson force-pushed the add-logger-dependency branch 2 times, most recently from fe0d08b to f7b8797 Compare August 4, 2024 16:32
@sds sds merged commit 3a954ed into enkessler:master Aug 6, 2024
31 checks passed
@sds
Copy link
Collaborator

sds commented Aug 6, 2024

Thanks!

@sds sds added the bug label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants