[PLA-1465] [PLA-1464] [PLA-1411] [PLA-1478] [PLA-1059] settings, royalty, UI fixes

[zlayine]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Bug fixes and UI improvements
• 📝 PR summary: This PR addresses several bug fixes and UI improvements in the Vue.js application. The changes include adjustments to font sizes, padding, and margins in various components, addition of new links, and changes to how certain values are calculated and displayed. It also includes some changes to the state management using Vuex.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and components, and it requires understanding of the Vue.js and Vuex framework to properly review the changes.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR includes a lot of changes in multiple files, which makes it a bit difficult to review. It would be better to split these changes into smaller PRs, each addressing a specific issue or improvement. This would make the review process easier and more efficient. Also, it would be beneficial to add tests to ensure the changes work as expected and do not introduce new bugs.

• 🤖 Code feedback:

  • relevant file: resources/js/components/pages/Settings.vue
    suggestion: It seems like the padding for the settings page has been reduced. While this might be a design decision, it's important to ensure that it doesn't negatively affect the user experience by making the page look cluttered or elements too close to each other. [medium]
    relevant line:

  • relevant file: resources/js/components/slideovers/collection/DetailsCollectionSlideover.vue
    suggestion: The royalty percentage calculation has been changed. It's crucial to ensure that this change doesn't affect other parts of the application where this calculation is used. Also, it would be good to add a comment explaining why this change was necessary. [important]
    relevant line:

    {{ Royalty.getRoyaltyPercentage(item) * 100 }}%

  • relevant file: resources/js/store/index.ts
    suggestion: The tokensCount has been added to the Vuex store. It's important to ensure that this state is updated correctly whenever a token is added or removed. Also, consider if there are other parts of the application that could benefit from using this state. [medium]
    relevant line: tokensCount: 0,

  • relevant file: resources/js/util/auth.guard.ts
    suggestion: A new condition has been added to the auth guard. It's important to ensure that this condition doesn't introduce any security vulnerabilities by allowing unauthorized access to certain routes. [important]
    relevant line: } else if (to.name == 'platform.collections' && !validConfig) {

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.