[PLA-1391] fix marketplace prices display

[zlayine]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Fixing the display of prices in the marketplace
• 📝 PR summary: This PR addresses a bug in the display of prices in the marketplace. It changes the price type from string to number and updates the display logic to handle prices greater than 100 differently.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and limited to a few lines of code.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems to be addressing the issue effectively. However, it would be beneficial to add some tests to ensure that the new logic works as expected in all scenarios.

• 🤖 Code feedback:

  • relevant file: resources/js/components/slideovers/marketplace/DetailsBidSlideover.vue
    suggestion: Consider extracting the price formatting logic into a separate function for better code readability and reusability. [medium]
    relevant line: {{ item.price > 100 ? formatPriceFromENJ(item.price) : item.price }}

  • relevant file: resources/js/components/slideovers/marketplace/DetailsListingSlideover.vue
    suggestion: It would be better to use a constant for the number 100 to make the code more readable and maintainable. [medium]
    relevant line: {{ item.price > 100 ? formatPriceFromENJ(item.price) : item.price }}

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[leonardocustodio]

Not sure this makes sense. I mean what if I use a token that has 1000 of price and the min unit is still 1?
I think what should be done here is to check if the price is referring to ENJ, if yes, you format it if not you leave it the way it is. You can check if it is using ENJ by checking to make & take if collectionId & tokenId = 0 is on the field take then it is ENJ