Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix urls in app with https #32

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix urls in app with https #32

merged 1 commit into from
Sep 21, 2023

Conversation

zlayine
Copy link
Contributor

@zlayine zlayine commented Sep 14, 2023

No description provided.

@zlayine zlayine self-assigned this Sep 14, 2023
@zlayine zlayine marked this pull request as draft September 14, 2023 16:15
@zlayine zlayine marked this pull request as ready for review September 14, 2023 16:33
@leonardocustodio
Copy link
Member

Does this need to be merged with the change done in .env to fix the issue with the assets?

@zlayine
Copy link
Contributor Author

zlayine commented Sep 21, 2023

@leonardocustodio It fixes just the urls with https, i will change the title of the PR.

@zlayine zlayine changed the title fix https with server build fix urls in app with https Sep 21, 2023
@leonardocustodio leonardocustodio merged commit 680e348 into master Sep 21, 2023
2 checks passed
@leonardocustodio leonardocustodio deleted the hotfix-https-build branch September 21, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v16Studios v16Studios v16Studios approved these changes

@leonardocustodio leonardocustodio leonardocustodio left review comments

Assignees

@zlayine zlayine

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zlayine @leonardocustodio @v16Studios