[PLA-1973] fix banner

[zlayine]

PR Type

bug_fix

---

Description

• Fixed the logic for determining banner visibility by checking local storage for the banner key.
• Ensured that the banner is not shown if the key is set to 'true' in local storage.

---

Changes walkthrough 📝

	Relevant files
Bug fix	DynamicBanner.vue Fix banner visibility logic using local storage                    resources/js/components/DynamicBanner.vue Modified the enabled computed property logic. Changed condition to check local storage for banner key. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Code Clarity The logic for checking local storage in the computed property might not account for null or undefined values which could lead to unexpected behavior.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add a check to ensure banner.value.key is defined before accessing localStorage Ensure that the localStorage.getItem(banner.value.key) call is safely handled in case banner.value.key is undefined or null, which could throw an error or behave unexpectedly. resources/js/components/DynamicBanner.vue [38] -return banner.value && localStorage.getItem(banner.value.key) !== 'true'; +return banner.value && banner.value.key && localStorage.getItem(banner.value.key) !== 'true'; Suggestion importance[1-10]: 8 Why: This suggestion correctly identifies a potential bug where banner.value.key might be undefined, leading to errors when accessing localStorage. Adding a check enhances the robustness of the code by preventing runtime errors.	8