Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-2072] fix beam details #175

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[PLA-2072] fix beam details #175

merged 2 commits into from
Nov 12, 2024

Conversation

zlayine
Copy link
Contributor

@zlayine zlayine commented Nov 12, 2024

PR Type

enhancement


Description

  • Enhanced the DetailsBeamSlideover.vue component to display claimLimit and claimsRemaining.
  • Updated the GetBeam GraphQL query to include claimLimit, claimsRemaining, and claimConditions.
  • Updated the GetBeams GraphQL query to include claimLimit, claimsRemaining, and claimConditions.

Changes walkthrough 📝

Relevant files
Enhancement
DetailsBeamSlideover.vue
Add claim limit and remaining claims display                         

resources/js/components/slideovers/beam/DetailsBeamSlideover.vue

  • Added display for claimLimit and claimsRemaining.
  • Updated the component to include new claim-related fields.
  • +18/-0   
    GetBeam.ts
    Extend GetBeam query with claim details                                   

    resources/js/graphql/query/beam/GetBeam.ts

  • Added claimLimit and claimsRemaining to the GraphQL query.
  • Included claimConditions in the query.
  • +3/-0     
    GetBeams.ts
    Extend GetBeams query with claim details                                 

    resources/js/graphql/query/beam/GetBeams.ts

  • Added claimLimit and claimsRemaining to the GraphQL query.
  • Included claimConditions in the query.
  • +3/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Data Handling
    Ensure that the new data fields claimLimit and claimsRemaining are properly validated and sanitized to prevent XSS vulnerabilities, especially since they are directly rendered in the DOM.

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @zlayine zlayine merged commit 3c1ce6d into master Nov 12, 2024
    4 checks passed
    @zlayine zlayine deleted the bugfix/pla-2072/fix-beam branch November 12, 2024 17:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants