Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-2049] remove keepalive from transfer forms #170

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

zlayine
Copy link
Contributor

@zlayine zlayine commented Oct 22, 2024

PR Type

Bug fix


Description

  • Removed the Keep Alive option from the BatchTransferForm and TransferTokenSlideover components.
  • Deleted all references to keepAlive in the form data and validation schemas.
  • Simplified the form structure by removing unnecessary fields.

Changes walkthrough 📝

Relevant files
Bug fix
BatchTransferForm.vue
Remove Keep Alive option from BatchTransferForm                   

resources/js/components/batch/forms/BatchTransferForm.vue

  • Removed Keep Alive checkbox from the form.
  • Deleted simpleKeepAlive and operatorKeepAlive references.
  • Updated validation schemas to remove keepAlive.
  • +0/-20   
    TransferTokenSlideover.vue
    Remove Keep Alive option from TransferTokenSlideover         

    resources/js/components/slideovers/token/TransferTokenSlideover.vue

  • Removed Keep Alive checkbox from the form.
  • Deleted keepAlive reference.
  • Updated validation schema to remove keepAlive.
  • +0/-9     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @zlayine zlayine merged commit 303b82d into master Oct 22, 2024
    4 checks passed
    @zlayine zlayine deleted the bugfix/pla-2049/transfer-form-keepalive branch October 22, 2024 14:14
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants