Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): add AWS ECR auth support #113

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

gmykhailiuta
Copy link

@gmykhailiuta gmykhailiuta commented Jun 15, 2023

Add support of AWS ECR.

Tested on both public and private ECR repositories:

Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  74s   default-scheduler  Successfully assigned dev-glr-linux-x86-cpu-s/test to ip-10-20-100-204.us-west-2.compute.internal
  Normal  Pulling    73s   kubelet            Pulling image "localhost:7439/<redacted>.dkr.ecr.us-west-2.amazonaws.com/<redacted>:alpine"
  Normal  Pulled     73s   kubelet            Successfully pulled image "localhost:7439/<redacted>.dkr.ecr.us-west-2.amazonaws.com/<redacted>:alpine" in 242.857334ms (242.896119ms including waiting)
  Normal  Created    73s   kubelet            Created container test
  Normal  Started    72s   kubelet            Started container test

@gmykhailiuta gmykhailiuta changed the title Add AWS ECR auth support feat(cache): add AWS ECR auth support Jun 20, 2023
@Nicolasgouze Nicolasgouze merged commit 79c2a36 into enix:main Jul 18, 2023
10 checks passed
@monkeynator
Copy link
Member

🎉 This PR is included in version 1.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@monkeynator
Copy link
Member

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aayushharwani-aidash
Copy link

I am getting this error, I am using version 1.3.0

Failed to pull image "localhost:7439/1234567890123.dkr.ecr.us-east-1.amazonaws.com/flask": rpc error: code = Unknown desc = failed to pull and unpack image "localhost:7439/1234567890123.dkr.ecr.us-east-1.amazonaws.com/flask:latest": failed to resolve reference "localhost:7439/1234567890123.dkr.ecr.us-east-1.amazonaws.com/flask:latest": pulling from host localhost:7439 failed with status code [manifests latest]: 500 Internal Server Error

@gmykhailiuta gmykhailiuta deleted the add-aws-ecr-support branch October 23, 2023 14:58
@gmykhailiuta
Copy link
Author

@aayushharwani-aidash, try to create a separate issue and attach more information to it (logs, IAM role/policy used, etc.).

@felipewnp
Copy link
Contributor

Hi @gmykhailiuta

Do you mind explaining how this works? Or pointing to somewhere that does?

I'm lost on how to use this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants