Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBZ-10505] Switch puma to phased-restart for hot restart #141

Open
wants to merge 2 commits into
base: next-release
Choose a base branch
from

Conversation

rupikakapoor
Copy link
Contributor

Description of your patch

Fix puma restart on deploy cause downtime

Recommended Release Notes

Fixed issue where puma restart on deploy cause downtime

Estimated risk

High

Components involved

All clients who use Puma as application stack

Dependencies

ey-puma

Description of testing done

Create v7 environment with puma
Boot Environment.
Run application deployment and monitor for application uptime while Application deployment at Restarting app servers step.

  • Check for if there is any downtime.
  • note how long it took to finish.
  • how many workers of puma was running.

QA Instructions

Create v7 environment with puma
Boot Environment.
Run application deployment and monitor for application uptime while Application deployment at Restarting app servers step.

  • Check for if there is any downtime.
  • note how long it took to finish.
  • how many workers of puma was running.
  • We need to test for an application with gemfile updates if deploy able to load that. (working with plantoeat to test that)

Copy link

@paulasaurus paulasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 46 please update "hot deploy" to "phased-restart deploy".

Then we also need to confirm what impact the extended amount of time required by a phased-restart has on the deploy process, in terms of it waiting for the restart to complete or not.

Updated Message to mention phased-restart instead of hot restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants