Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SimConnectionManager to manage multiple connections #87

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

charlestytler
Copy link
Collaborator

Supports #83

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #87 (bfba344) into master (20d0ca0) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   92.39%   92.61%   +0.21%     
==========================================
  Files          59       61       +2     
  Lines        2472     2544      +72     
  Branches       39       39              
==========================================
+ Hits         2284     2356      +72     
  Misses        188      188              
Flag Coverage Δ
Cpp 96.61% <100.00%> (+0.10%) ⬆️
ReactJS 54.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...amdeckContext/ExportMonitors/ImageStateMonitor.cpp 96.77% <ø> (ø)
...reamdeckContext/ExportMonitors/ImageStateMonitor.h 100.00% <ø> (ø)
...eamdeckContext/ExportMonitors/IncrementMonitor.cpp 100.00% <ø> (ø)
...treamdeckContext/ExportMonitors/IncrementMonitor.h 100.00% <ø> (ø)
.../StreamdeckContext/ExportMonitors/TitleMonitor.cpp 100.00% <ø> (ø)
...pp/StreamdeckContext/ExportMonitors/TitleMonitor.h 100.00% <ø> (ø)
.../StreamdeckContext/SendActions/IncrementAction.cpp 95.23% <ø> (ø)
.../StreamdeckContext/SendActions/MomentaryAction.cpp 100.00% <ø> (ø)
...cpp/StreamdeckContext/SendActions/SwitchAction.cpp 100.00% <ø> (ø)
...ackend-cpp/StreamdeckContext/StreamdeckContext.cpp 100.00% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20d0ca0...bfba344. Read the comment docs.

@charlestytler charlestytler merged commit fc53896 into master Jan 16, 2022
@charlestytler charlestytler deleted the SimConnectionManager branch January 16, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants