refactor(daemon): Synchronize host makeUnconfined()
#2124
Merged
+244
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
rekmarks
requested review from
kumavis and
kriskowal
and removed request for
kumavis
rekmarks
force-pushed
the
rekmarks-synchronize-makeUnconfined
branch
from
65f7bfa to
63a7d1c
Compare
kumavis
reviewed
Mar 8, 2024
rekmarks
force-pushed
the
rekmarks-delete-makeWorker
branch
from
6516b25 to
9fe0d6c
Compare
|
@kumavis I hope to simplify things as the synchronization effort continues, but the simplest way of doing things may not reveal itself until late in that process. |
rekmarks
force-pushed
the
rekmarks-synchronize-makeUnconfined
branch
from
63a7d1c to
5d356f7
Compare
rekmarks
force-pushed
the
rekmarks-synchronize-makeUnconfined
branch
from
5d356f7 to
aab0a1a
Compare
kriskowal
approved these changes
Mar 8, 2024
| // Regression test for: https://github.com/endojs/endo/issues/2021 | ||
| test('eval-mediated worker name', async t => { | ||
| // Regression test for https://github.com/endojs/endo/issues/2021 | ||
| test.failing('eval-mediated worker name', async t => { |
There was a problem hiding this comment.
I am consulting my exterminator as to our next steps.
Synchronizes the host's `makeUnconfined()` per #2086. Refactoring `daemon.js` in support of this goal fixed one bug while revealing another. In particular, #2074 is progressed by enabling indirect cancellation of caplets via their workers. The issue is not resolved since indirect cancellation of caplets via their caplet dependencies still does not work as intended. A new, failing regression test has been added for this specific case. The revealed bug is #2021, which we believed to be fixed by #2092. Rather than fixing the bug, that PR concealed it by always creating a new incarnation of `eval` formula workers, even if they already existed. The regression test for #2021 has been marked as failing, and we will have to find a different solution for it.
rekmarks
force-pushed
the
rekmarks-synchronize-makeUnconfined
branch
from
aab0a1a to
a239f10
Compare
kriskowal
reviewed
Mar 11, 2024
| * Helper for callers of `incarnateNumberedGuest`. | ||
| * @param {string} hostFormulaIdentifier - The formula identifier of the host. | ||
| */ | ||
| const incarnateGuestDependencies = async hostFormulaIdentifier => |
There was a problem hiding this comment.
Should be provideGuestDependencies. Doesn’t create formulas. Renaming formulate* functions should make that distinction clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses: #2086
Synchronizes the host's
makeUnconfined()per #2086. Refactoringdaemon.jsin support of this goal fixed one bug while revealing another.In particular, #2074 is progressed by enabling indirect cancellation of caplets via their workers. The issue is not resolved since indirect cancellation of caplets via their caplet dependencies still does not work as intended. A new, failing regression test has been added for this specific case.
The revealed bug is #2021, which we believed to be fixed by #2092. Rather than fixing the bug, that PR concealed it by always creating a new incarnation of
evalformula workers, even if they already existed. The regression test for #2021 has been marked as failing, and we will have to find a different solution for it.