Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(daemon): work around for "yarn endo cat" #1873

Closed
wants to merge 1 commit into from
Closed

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Dec 1, 2023

yarn v1 seems to require a newline at the end of stdout in order to display. not sure why

works fine without the yarn invocation wrapper

❯ yarn -v
1.22.19

test setup (note lack of newline):

❯ cat test.txt                        
hello world%  
❯ yarn endo store test.txt --name text

before:

❯ yarn endo cat text                  
yarn run v1.22.19
$ /home/xyz/Development/endo/node_modules/.bin/endo cat text
Done in 0.25s.

after:

❯ yarn endo cat text             
yarn run v1.22.19
$ /home/xyz/Development/endo/node_modules/.bin/endo cat text
hello world
Done in 0.25s.

@kumavis kumavis changed the base branch from master to endo December 1, 2023 23:05
@kumavis kumavis requested a review from kriskowal December 1, 2023 23:05
@kumavis kumavis mentioned this pull request Dec 1, 2023
3 tasks
@kumavis kumavis force-pushed the fix-daemon-cli-cat branch from 97f24a4 to 7c2af69 Compare December 1, 2023 23:09
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to land this change. It’s one of those fixes that causes irreparable breakage elsewhere, like storing and retrieving binary data, or adds an extra newline if the input had such.

Shame about yarn behavior! That’s a bug that it doesn’t flush on end without a line terminator.

@kumavis kumavis closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants