refactor(daemon): Apply suggestions from code review

Co-authored-by: Kris Kowal <[email protected]>
endojs · Feb 22, 2024 · bdaf855 · bdaf855
1 parent e285f4c
commit bdaf855
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/daemon/src/daemon.js b/packages/daemon/src/daemon.js
@@ -637,6 +637,8 @@ const makeDaemonCore = async (
       provideControllerForFormulaIdentifier(formulaIdentifier)
     );
     return controller.external.then(value => {
+      // Release the value to the public only after ensuring
+      // we can reverse-lookup its nonce.
       if (typeof value === 'object' && value !== null) {
         formulaIdentifierForRef.set(value, formulaIdentifier);
       }

diff --git a/packages/daemon/test/test-endo.js b/packages/daemon/test/test-endo.js
@@ -881,8 +881,7 @@ test('name and reuse inspector', async t => {
   await stop(locator);
 });
 
-// This tests behavior that previously failed due to a bug.
-// See: https://github.com/endojs/endo/issues/2021
+// Regression test for: https://github.com/endojs/endo/issues/2021
 test('eval-mediated worker name', async t => {
   const { promise: cancelled, reject: cancel } = makePromiseKit();
   t.teardown(() => cancel(Error('teardown')));