Skip to content

Commit

Permalink
Increased epsilon value to 130ms of TestTiming.testGetMicrosecondsTim…
Browse files Browse the repository at this point in the history
…erAgaintsSleep and TestTiming.testGetMillisecondsTimerAgaintsSleep on macOS when running on GitHub Action.
  • Loading branch information
end2endzone committed Apr 2, 2021
1 parent c1b3535 commit d40a319
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/TestTiming.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ namespace ra { namespace timing { namespace test
#elif defined(__APPLE__)
double epsilon = 15.0;
if (ra::testing::IsGitHubActions()) {
// On Github Action, the observed delays seems to be increased by about 60ms for GetMicrosecondsTimer()
epsilon = 70.0;
// On Github Action, the observed delays seems to be increased up to 130ms for GetMicrosecondsTimer()
epsilon = 130.0;
}
#else
double epsilon = 1.0;
Expand Down Expand Up @@ -163,8 +163,8 @@ namespace ra { namespace timing { namespace test
#elif defined(__APPLE__)
double epsilon = 15.0;
if (ra::testing::IsGitHubActions()) {
// On Github Action, the observed delays seems to be increased by about 90ms for GetMillisecondsTimer()
epsilon = 100.0;
// On Github Action, the observed delays seems to be increased by about 130ms for GetMillisecondsTimer()
epsilon = 130.0;
}
#else
double epsilon = 1.0;
Expand Down

0 comments on commit d40a319

Please sign in to comment.