Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientgen/{ts,js}: default content type on raw request #1717

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

fredr
Copy link
Member

@fredr fredr commented Jan 17, 2025

node-fetch will automatically figure out the content type (such as FormData) and handle it for certain types, see https://fetch.spec.whatwg.org/#concept-bodyinit-extract and it seems like relying on that logic for raw endoints would be a sane default

@fredr fredr self-assigned this Jan 17, 2025
@encore-cla
Copy link

encore-cla bot commented Jan 17, 2025

All committers have signed the CLA.

@fredr fredr force-pushed the fredr/default-content-type branch from e116385 to 86f996d Compare January 17, 2025 13:19
@fredr fredr changed the title clientgen/ts: default content type on raw request clientgen/{ts,js}: default content type on raw request Jan 17, 2025
@fredr fredr marked this pull request as ready for review January 17, 2025 13:29
@fredr fredr requested a review from eandre January 17, 2025 13:29
@fredr fredr force-pushed the fredr/default-content-type branch from 86f996d to cfd2c55 Compare January 20, 2025 07:51
@fredr fredr force-pushed the fredr/default-content-type branch from cfd2c55 to 3b099e9 Compare January 23, 2025 09:36
@fredr fredr merged commit 8184e3d into main Jan 23, 2025
4 checks passed
@fredr fredr deleted the fredr/default-content-type branch January 23, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants