Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable democracy #366

Merged
merged 13 commits into from
Mar 24, 2024
Merged

enable democracy #366

merged 13 commits into from
Mar 24, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Mar 24, 2024

this adds enactment of approved proposals and cli commands

  • confirmationTime = 5min (similar enough to 21 blocks, so CI shouldn't last much longer)
  • proposalLifetime = 20min (so entire proposals can be tested within one Gesell cycle)
  • more verbose community parameter printouts for list-communities
  • some more good-scout cleanup

companion tutorial: https://book.encointer.org/tutorials-democracy.html

Comment on lines +529 to 530
pub const ConfirmationPeriod: Moment = 5 * 60 * 1000; // [ms]
pub const ProposalLifetime: Moment = 20 * 60 * 1000; // [ms]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5min confirmation and 20min lifetime seem appropriate for Gesell testing

Comment on lines +411 to +412
type OnCeremonyPhaseChange =
(pallet_encointer_ceremonies::Pallet<Runtime>, pallet_encointer_democracy::Pallet<Runtime>);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this finally enacts approved proposals upon Registering start

@brenzi brenzi requested a review from clangenb March 24, 2024 20:30
@brenzi
Copy link
Member Author

brenzi commented Mar 24, 2024

CC @pifragile. kudos for your work on the democracy pallet!

@brenzi brenzi merged commit ba9c25d into master Mar 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant