-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] add list-reputables #332
Conversation
I'll need to check the numbers and the wording, but it looks great. |
strange, I get the following error:
|
with the above fix I was able to test against a local dev node, just running bootstrap_demo_community.py twice. same result:
|
ok, since the 0.9.42 merge we can't test against kusama anymore until we have an rpc node running with the newest version (breaking changes in client).
I'll try to spawn a local one for testing |
Pushed the fixes. It is working for me now. |
ok, I believe it now does what it should. however, the numbers don't match to the explorer ones....need to find out why could be a difference in which cycle range is queried (depending on current ceremony phase?) |
most likely, our explorer silently counts noshows as reputables. encointer/explorer#132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks a lot @haerdib very nice work!
…-reputations-commitment (#343) * Faucet (#333) * integrate faucet locally * benchmarking for faucet and reputation commitments * implement faucet cli * implement faucet integration tests * fix cli and weights * weights * clippy * unpatch pallets * taplo fmt * update cargo.lock * bump v1.4.0 * [cli] add list-reputables (#332) * add list-reputables * naming and underflow fix * fix option query and max numbers * refactor names and change to correct storage. not yet ok * extracting AccountId key from doublemap storagekey tail * count noshows as well * fmt * fix the merge --------- Co-authored-by: Alain Brenzikofer <[email protected]> Co-authored-by: brenzi <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> * bump 1.4.1 * whitelist bypass integration (#335) * whitelist bypass integration * bump versions --------- Co-authored-by: Alain Brenzikofer <[email protected]> * faucet cli improvements (#337) * faucet cli imporvements * add help for whitelist * fix hardcoded event index --------- Co-authored-by: Alain Brenzikofer <[email protected]> * fix try runtime (#342) * fix missing feature flags * fix node build * add try-runtime and benchmarks to CI * fmt * [node] fix feature flag --------- Co-authored-by: Christian Langenbacher <[email protected]> * community metadata extension migration (#341) * integrate communitymetadata extension. builds * rename ceremonies migration accordingly * add try-runtime and benchmarks to CI * point to explicit release branch of pallets * bump versions * fmt * lift patches * minor version bump * GHA: fix deprecation warnings (save-state, set-output, Nodejs12) (#338) * gha: bump rust-cache action * gha: bump setup-python action * gha: remove deprecated set-output commands * gha: bump cancel-action action * gha: bump cache action * gha: bump docker/login-action * gha: bump docker/setup-buildx-action * gha: bump actions/checkout * gha: bump docker/build-push-action * gha: bump dev-drprasad/delete-tag-and-release * gha: specify actions/checkout action version * gha: specify actions/download-artifact action version * extend changes to new job --------- Co-authored-by: brenzi <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> * Faucet (#333) * integrate faucet locally * benchmarking for faucet and reputation commitments * implement faucet cli * implement faucet integration tests * fix cli and weights * weights * clippy * unpatch pallets * taplo fmt * update cargo.lock * teerex followup * client: remove mistakenly added pallet-encointer-communities * client: add logs to bootstrap_demo_community.py --------- Co-authored-by: pifragile <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> Co-authored-by: Bigna Härdi <[email protected]> Co-authored-by: brenzi <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> Co-authored-by: Christian Langenbacher <[email protected]> Co-authored-by: echevrier <[email protected]>
closes #315
I tested it on the Kusama node with the following cmd:
../target/release/encointer-client-notee -u wss://kusama.api.encointer.org -p 443 list-reputables -v
The number of the total reputables matches the one of
reputableCount
.@brenzi is this what you had somewhat in mind?
Output:
Output without verbose, but with
--at
:closes #315