Add Private Network Access support in CORSMiddleware #2621
+179
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chromium-based browsers now enforce requests from websites in public network to localhost or private network endpoints and from private to localhost to "ask for permission" from server with
OPTIONS
pre-flight request. See more in their blog post. It is also applied to navigation fetches (e.g. iframes, popups): blog postFor it I added
allow_private_network
field inCORSMiddleware
constructor as discussed in #2509. Also, I renamed formerpreflight_response
tocors_preflight_response
to addpna_preflight_response
method to support pre-flight request in no-cors mode. Tests were also updated to cover new functionality.I invite other contributors and maintainers to work on this pull request to be merged in future. Google is going to enforce various restrictions in their platform, so our instruments must be ready to deal with it!
Checklist