Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gen-delims escaping behaviour in path/query/fragment #2701

Merged
merged 1 commit into from
May 9, 2023

Conversation

tomchristie
Copy link
Member

Fix which gen-delims need to be escaped for path/query/fragment components in URL.

  • path now allows : / [ ] @ instead of : @ /
  • query now allows : / [ ] @ ? instead of / ?
  • fragment now allows : / [ ] @ ? # instead of / ?

Closes #2694

@tomchristie tomchristie added the bug Something isn't working label May 9, 2023
@tomchristie tomchristie requested a review from a team May 9, 2023 10:47
Copy link
Member

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tomchristie tomchristie merged commit ee432c0 into master May 9, 2023
@tomchristie tomchristie deleted the fix-gen-delims-escaping branch May 9, 2023 13:20
@epenet
Copy link
Contributor

epenet commented May 14, 2023

Is there a plan to issue a hotfix/patch release for this?

@tomchristie
Copy link
Member Author

@epenet Sure - would you (or anyone) like to attempt a pull request with a minor version bump.
I'll help guide through the process.

@epenet
Copy link
Contributor

epenet commented May 16, 2023

@epenet Sure - would you (or anyone) like to attempt a pull request with a minor version bump. I'll help guide through the process.

I created PR #2702, but I'm a little confused here as it seems there is already a v0.24.1 branch in progress: https://github.com/encode/httpx/tree/version-0.24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Square brackets no longer work
3 participants