Fix heartbeats not being sent

enbility · Feb 5, 2024 · 8f66375 · 8f66375
1 parent 280e5be
commit 8f66375
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/spine/entity_local.go b/spine/entity_local.go
@@ -66,11 +66,6 @@ func (r *EntityLocal) GetOrAddFeature(featureType model.FeatureTypeType, role mo
 	f.SetDescriptionString(description)
 	r.features = append(r.features, f)
 
-	if role == model.RoleTypeServer && featureType == model.FeatureTypeTypeDeviceDiagnosis {
-		// Update HeartbeatManager
-		r.device.HeartbeatManager().SetLocalFeature(r, f)
-	}
-
 	return f
 }
 

diff --git a/spine/feature_local.go b/spine/feature_local.go
@@ -69,6 +69,14 @@ func (r *FeatureLocal) AddFunctionType(function model.FunctionType, read, write
 		return
 	}
 	r.operations[function] = NewOperations(read, write)
+
+	if r.role == model.RoleTypeServer &&
+		r.ftype == model.FeatureTypeTypeDeviceDiagnosis &&
+		function == model.FunctionTypeDeviceDiagnosisHeartbeatData {
+		// Update HeartbeatManager
+		r.Device().HeartbeatManager().SetLocalFeature(r.Entity(), r)
+	}
+
 }
 
 func (r *FeatureLocal) AddResultHandler(handler api.FeatureResultInterface) {