Fix: have CurrentLimits method in opev and oscev filter for LoadControlLimitDescription instead of MeasurementDescription #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itDescriptionData instead of MeasurementDescriptionData
|
Thank you @AhmedMagdyCoretech , this looks great! |
DerAndereAndi
requested changes
Nov 26, 2024
… for measurement ID in relevant LoadControlLimitDescriptions
… obtained from relevant load control limit descritpions. they need not exist in the measurement description list.
Thank you for the feedback. All the issues have been duly resolved. |
DerAndereAndi
requested changes
Nov 28, 2024
Thank you for the feedback. Not so picky, I would say. Aptly addressed. |
DerAndereAndi
approved these changes
Nov 28, 2024
|
Thank you very much @AhmedMagdyCoretech ! |
AhmedMagdyCoretech
deleted the
feature/LoadControlDescFilterForPermittedValueSet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the "ScopeType" field in the LoadControlLimitDescription is more relevant (with a value of "overloadProtection" and "selfConsumption" for OPEV and OSCEV, respectively), it shall be used as the filter for obtaining the relevant ElectricalConnectionPermittedValueSetListData items in the CurrentLimits getters for OPEV and OSCEV. From the relevant LoadControlLimitDescriptionData items, one can get their corresponding measurement IDs and use them to filter for relevant parameter description items.