Fix ma/mpc usecase to validate the correct actor type #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actor in this use case should be a MonitoringAppliance, but it should connect to actors of type MonitoredUnit.
|
Nice catch @sthelen-enqs . Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ma/mpc usecase should filter for actors of type MonitoredUnit but was filtering for actors of type MonitoringAppliance which lead to the uc never finding any entities.
This PR also adds a commit which adjusts the string representation of the ma/mpc UseCaseSupportUpdate EventType from "ma-mpc-oscev-UseCaseSupportUpdate" to "ma-mpc-UseCaseSupportUpdate" as it isn't relevant here. This is technically an API-breaking change, but all subscribers should be using the constant mpc.UseCaseSupportUpdate instead of its string representation and therefore automatically always use the correct variant for their version of eebus-go. I could, however, drop the commit from this PR if preferred.