Skip to content

Commit

Permalink
Make DataUpdateHeartbeat event names more consistent (#141)
Browse files Browse the repository at this point in the history
This also allows differentiating between eglpc.DataUpdateHeartbeat and
cslpc.DataUpdateHeartbeat events.

While syncing my branch on dev, I saw
#137 and noticed that the
DataUpdateHeartbeat events for eg/lpc and cs/lpc used the same
identifier which means they can't be differentiated from another over
e.g. json-rpc. I also took the liberty of changing the "uclppserver-"
identifier to "cs-lpp-" to make it consistent with the other event
names.
  • Loading branch information
DerAndereAndi authored Nov 11, 2024
2 parents 36f8cc2 + 6f64d63 commit bb09c16
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion usecases/cs/lpp/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ const (
// E.g. going into or out of the Failsafe state
//
// Use Case LPP, Scenario 3
DataUpdateHeartbeat api.EventType = "uclppserver-DataUpdateHeartbeat"
DataUpdateHeartbeat api.EventType = "cs-lpp-DataUpdateHeartbeat"
)
2 changes: 1 addition & 1 deletion usecases/eg/lpc/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ const (
// E.g. going into or out of the Failsafe state
//
// Use Case LPC, Scenario 3
DataUpdateHeartbeat api.EventType = "cs-lpc-DataUpdateHeartbeat"
DataUpdateHeartbeat api.EventType = "eg-lpc-DataUpdateHeartbeat"
)
2 changes: 1 addition & 1 deletion usecases/eg/lpp/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ const (
// E.g. going into or out of the Failsafe state
//
// Use Case LPP, Scenario 3
DataUpdateHeartbeat api.EventType = "cs-lpp-DataUpdateHeartbeat"
DataUpdateHeartbeat api.EventType = "eg-lpp-DataUpdateHeartbeat"
)

0 comments on commit bb09c16

Please sign in to comment.