Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: relicense as Apache 2 #315

Merged
merged 1 commit into from
Feb 21, 2024
Merged

chore: relicense as Apache 2 #315

merged 1 commit into from
Feb 21, 2024

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Oct 13, 2023

No description provided.

@rjzak rjzak requested review from bstrie, a team and haraldh as code owners October 13, 2023 02:06
@rjzak rjzak requested a review from npmccallum October 13, 2023 02:09
npmccallum
npmccallum requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@npmccallum npmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't remove the copyright header. That is still valid and is useful for tracking the history of the IP.

  2. You need to remove all the mentions of copyright assignment since that is no longer necessary.

@rjzak
Copy link
Member Author

rjzak commented Oct 21, 2023

@npmccallum I think I did what was asked, but I'm not sure I understand what is meant by removing copyright assignment. Is that the authors line in Cargo.toml? Should I change it to "Enarx Project"?

@rjzak rjzak force-pushed the apache2 branch 2 times, most recently from 49e4293 to fed0b78 Compare October 21, 2023 18:01
@rjzak
chore: relicense as Apache 2
17e3ccc 
Signed-off-by: Richard Zak <[email protected]>
@rjzak rjzak requested a review from npmccallum October 21, 2023 18:21
@rjzak
Copy link
Member Author

rjzak commented Nov 10, 2023

@npmccallum gentle nudge

@rjzak rjzak mentioned this pull request Nov 15, 2023
Open
2 tasks
@dcmiddle
Copy link

I don't have a maintainer voice here, but from the CCC threads and the comments in the PR, it looks like this is ready to merge.

@npmccallum npmccallum merged commit 455c053 into enarx:main Feb 21, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmccallum npmccallum npmccallum approved these changes

@bstrie bstrie Awaiting requested review from bstrie

@haraldh haraldh Awaiting requested review from haraldh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjzak @dcmiddle @npmccallum