deserialize_bytes with data bigger than 4k #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
changed the title
|
Thank you for the PR! |
RCasatta
added a commit
to Blockstream/gdk
that referenced
this pull request
Oct 26, 2023
we switched to ciborium because serde_cbor it's unmantained. However, serde_cbor never gave us trouble, while ciborium had the "invalid type: bytes, expected bytes" bug, which has been attempted to be solved upstream in enarx/ciborium#97 Apart that we have no input on the MR yet, in trying to use the patched version we encountered the error: "invalid type: string, expected map" which is probably due to the fact the patched version is on master and not just the bug fix from the tagged version we use. While this later approach could work, ciborium doesn't look that reliable so we decided to switch back to serde_cbor for the time being.
LeoComandini
pushed a commit
to Blockstream/gdk
that referenced
this pull request
Oct 26, 2023
we switched to ciborium because serde_cbor it's unmantained. However, serde_cbor never gave us trouble, while ciborium had the "invalid type: bytes, expected bytes" bug, which has been attempted to be solved upstream in enarx/ciborium#97 Apart that we have no input on the MR yet, in trying to use the patched version we encountered the error: "invalid type: string, expected map" which is probably due to the fact the patched version is on master and not just the bug fix from the tagged version we use. While this later approach could work, ciborium doesn't look that reliable so we decided to switch back to serde_cbor for the time being.
rjzak
force-pushed
the
bytes_bigger_than_4k
branch
from
187988c to
6ac789d
Compare
|
This won't work as-is because Ciborium aims to work in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #96
The test format is not like the others but I didn't find a way to leverage the existing test suite to expose the error.