fix: invalid allocation requests #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid data can lead to allocating too much memory. Only preallocate up to 1024 `Value` objects. Fixes: enarx#115 Signed-off-by: Ahmed Charles <[email protected]>
|
Fantastic! Just looks like clippy doesn't like an unused import. |
rjzak
approved these changes
Feb 26, 2024
|
Sorry, I had an interim fix that used |
| @@ -124,7 +124,9 @@ impl<'de> serde::de::Visitor<'de> for Visitor { | |||
|
|
|||
| #[inline] | |||
| fn visit_map<A: de::MapAccess<'de>>(self, mut acc: A) -> Result<Self::Value, A::Error> { | |||
| let mut map = Vec::<(Value, Value)>::with_capacity(acc.size_hint().unwrap_or(0)); | |||
| let mut map = Vec::<(Value, Value)>::with_capacity( | |||
| acc.size_hint().filter(|&l| l < 1024).unwrap_or(0), | |||
There was a problem hiding this comment.
Description says:
Only preallocate up to 1024 Value objects.
But this code will not allocate at all when size hint >= 1024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid data can lead to allocating too much memory. Only preallocate up to 1024
Valueobjects.Fixes: #115