Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert some USE_GYRO_DATA_ANALYSE and USE_GYRO_LPF2 gating #936

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Oct 26, 2023

  • revert some USE_GYRO_DATA_ANALYSE and USE_GYRO_LPF2 gating because C compiler sucks
  • why: because compiler reports warning: embedding a directive within macro arguments is not portable, which reports that ifdef inside macros may have unexpected results depending on compiler/devices.
  • reverting these requires reverting variables. and thus revert MSP read of values. (but not MSP write of 0's)

Copy link
Member

@Quick-Flash Quick-Flash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this helps remove potential issues of undefined behavior. Thanks!

@nerdCopter nerdCopter force-pushed the 20231026_revert_USE_GYRO_DATA_ANALYSE_and_USE_GYRO_LPF2_gating branch from e2cc48d to c013d41 Compare October 27, 2023 14:31
@nerdCopter
Copy link
Member Author

fixed. tested on both unsoldered FC with undef's and LOS tested on headless whoop with undef's

@nerdCopter nerdCopter marked this pull request as ready for review October 27, 2023 15:54
@nerdCopter nerdCopter merged commit b2117eb into emuflight:master Oct 27, 2023
6 checks passed
@nerdCopter nerdCopter deleted the 20231026_revert_USE_GYRO_DATA_ANALYSE_and_USE_GYRO_LPF2_gating branch October 27, 2023 15:54
@nerdCopter nerdCopter restored the 20231026_revert_USE_GYRO_DATA_ANALYSE_and_USE_GYRO_LPF2_gating branch June 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants