Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more descriptive USBD_PRODUCT_STRING when not defined in target.h #1073

Merged
merged 1 commit into from
Jul 12, 2024
Merged

more descriptive USBD_PRODUCT_STRING when not defined in target.h #1073

merged 1 commit into from
Jul 12, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Jul 9, 2024 •
edited
Loading

  • before:
    image

  • after:
    image

  • when defined in target.h:
    image

@nerdCopter nerdCopter requested a review from Quick-Flash July 9, 2024 16:37
@nerdCopter
Copy link
Member Author

nerdCopter commented Jul 9, 2024 •
edited
Loading

i attempted to stringify BOARD_NAME, but no matter any variations and attempts i could not get such to work.
i tried with the already existing STR() and my own home-grown versions, but nothing worked.

@nerdCopter nerdCopter merged commit f7b769a into emuflight:master Jul 12, 2024
6 checks passed
@nerdCopter nerdCopter deleted the 20240709_fix_USBD_PRODUCT_STRING branch July 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quick-Flash Quick-Flash Awaiting requested review from Quick-Flash

Assignees
No one assigned
Labels
0.4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nerdCopter