Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass gelf library level mapping #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivan-mjch
Copy link

This gelf output plugin maps syslog levels to gelf library levels (which I think are ruby logger levels)
and then the gelf library maps them back to syslog levels. This patch avoids the conversion,
storing them as plain integers defines an identity mapping for the gelf library to use.

This patch should avoid the loss of message level information when it is 0 1 or 5.
It works on our systems.

@emsearcy
Copy link
Owner

emsearcy commented Jan 5, 2017

I'd prefer if this could just get fixed upstream as per graylog-labs/gelf-rb#52 so we use their library in clean fashion, rather than have to work around it...

emsearcy/gelf-rb@65dd04e

@ivan-mjch
Copy link
Author

I didn't see that.

Personally, I would ask for support for using numeric syslog levels directly,
as mapping it back and forth still seems a bit silly, but yes, that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants