Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for premature exit from decoding #3

Open
wants to merge 1 commit into
base: libpng16
Choose a base branch
from

Conversation

pieper
Copy link

@pieper pieper commented Apr 12, 2020

Need to change errors to warnings to read sample file with this code:

https://github.com/covictory/pngdump

https://github.com/covictory/pngdump/blob/master/testsite/cxr16bit.png

@kripken
Copy link
Member

kripken commented Apr 13, 2020

Thanks @pieper , should these be submitted upstream perhaps? (they don't seem specific to emscripten at first glance)

@pieper
Copy link
Author

pieper commented Apr 13, 2020

Hi - good question - I didn't try but could investigate.

I noticed a note that something similar had been done in other parts of the libpng code. Maybe this is just in the way error handling happens in emscripten leads to an abort instead of just a message.

I'm rebuilding now with this project's build script and can see what happens for different libpng versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants