This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
Fix mutex ownership in pthread SDL_CondWait() #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a following bug in pthread versions of
SDL_CondWait()
andSDL_CondWaitTimeout()
:When call to
pthread_cond_wait()
(orpthread_cond_timedwait()
) succeeds and the current thread reacquires thepthread_mutex
, it doesn't properly update its wrapper (theSDL_mutex
object). IfFAKE_RECURSIVE_MUTEX
is set, this leads to problems in the following scenario: