Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with pycrdt v0.12.2 #1512

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@davidbrochart
Copy link
Contributor Author

The error seems to be:

Running build script
Setting up cross-python
ERROR: Version mismatch: host=3.11, build=3.12

@IsabelParedes
Copy link
Member

It seems to be installing

cross-python_emscripten-wasm32-3.11.3-py312h6dbc830_10.tar.bz2

instead of the correct

cross-python_emscripten-wasm32-3.11.3-py311hfc8b64e_10.tar.bz2

Pinning python should fix it

requirements:
  build:
  - cross-python_${{target_platform}}
  - python == 3.11

But should this package (cross-python_emscripten-wasm32-3.11.3-py312h6dbc830_10.tar.bz2) with mismatched python versions even exist? @DerThorsten

@davidbrochart
Copy link
Contributor Author

pydantic-core doesn't seem to build either: #1517.

@DerThorsten
Copy link
Contributor

we should delete (cross-python_emscripten-wasm32-3.11.3-py312h6dbc830_10.tar.bz2

@IsabelParedes
Copy link
Member

pydantic-core doesn't seem to build either: #1517.

This one fails because the recipe doesn't include a compiler in the build environment, and without it it installs the newer version of emscripten.

emscripten_emscripten-wasm32 ┆ 3.1.73

And this package currently has some issues.

@davidbrochart
Copy link
Contributor Author

Now failing with: Failed to parse emcc version.

@davidbrochart
Copy link
Contributor Author

Now the error looks like a Rust compiler issue:

error[E0599]: no function or associated item named `default` found for struct `yrs::undo::Options` in the current scope
    --> src/undo.rs:26:36
   |
26 |         let mut options = Options::default();
   |                                    ^^^^^^^ function or associated item not found in `Options`

I see the version of rustc is 1.79.0, could it be upgraded to a newer version?

@davidbrochart
Copy link
Contributor Author

I opened #1518.

@DerThorsten
Copy link
Contributor

@davidbrochart

#[cfg(not(target_family = "wasm"))]
impl Default for Options {
    fn default() -> Self {
        Options {
            capture_timeout_millis: 500,
            tracked_origins: HashSet::new(),
            capture_transaction: None,
            timestamp: Arc::new(crate::sync::time::SystemClock),
        }
    }
}

https://github.com/y-crdt/y-crdt/blob/main/yrs/src/undo.rs#L882

seems like this is not available when using wasm

@davidbrochart
Copy link
Contributor Author

Thanks, I'm wondering if this is because of the system clock.

@davidbrochart
Copy link
Contributor Author

I opened y-crdt/y-crdt#520.

@davidbrochart davidbrochart reopened this Jan 9, 2025
@davidbrochart davidbrochart changed the title Update with pycrdt v0.12.1 Update with pycrdt v0.12.2 Jan 9, 2025
@davidbrochart
Copy link
Contributor Author

The error seems to be: ModuleNotFoundError: No module named '_ssl'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants