Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for invalid symbol names in llvm-nm output. #17888

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Check for invalid symbol names in llvm-nm output. #17888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a67774
Check for invalid symbol names in llvm-nm output.
sbc100 Sep 19, 2022
49b28c1
Update tools/building.py
sbc100 Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tools/building.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,9 @@ def parse_llvm_nm_symbols(output):
filename_pos = entry_pos

filename = line[:filename_pos]
if entry_pos + 13 >= len(line):
exit_with_error('error parsing output of llvm-nm: `%s`\nIf the symbol name here contains a colon, and starts with __invoke_, then the object file was likely built with an old version of llvm (please rebuild it).' % line)

status = line[entry_pos + 11] # Skip address, which is always fixed-length 8 chars.
symbol = line[entry_pos + 13:]

Expand Down