Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animation-prop): decommission old animation-prop.ts and generalize the new one #1660

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(animation-prop): decommission old animation-prop.ts and generalize the new one #1660

merged 1 commit into from
Nov 21, 2024
+23 −26

Conversation

joseacabaneros
Copy link
Member

animationProp was a constant used in somewhen, but with Vue3 we have a type created AnimationProp.
This PR removes the old constant and refactors where it was used.
It also simply the AnimationProp type to improve the usability, compiling it as
Screenshot 2024-11-20 at 18 49 01

 * String for 'ul'
 * Object for `DefineComponent` type
 * Function for `() => NoElement`

@joseacabaneros joseacabaneros requested a review from a team as a code owner November 20, 2024 18:00
@diegopf diegopf merged commit 493b6bd into main Nov 21, 2024
4 checks passed
@diegopf diegopf deleted the animation-prop-alignment branch November 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegopf diegopf diegopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseacabaneros @diegopf