feat: add lang parameter to the queriesPreview hash #1653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
When we made the implementation of cached the queries preview, we didn't realize that a queryPreview could work with different languages, but obtain different results.
Now when we change the language and a queryPreview return results in both languages we are not making a new request of the query with the new language. That's because the query is already saved in the state.
The change that we have made in this PR is to add the lang param to the QueryPreview hash.
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Install this version in Bigbuy, change the language and set queriesPreview to [].
Then check that the first carousel (
innovagoods
) changes it results when you set a new lang.Checklist: