Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new base slider component #1650

Merged
merged 9 commits into from
Nov 4, 2024
Merged

feat: add new base slider component #1650

merged 9 commits into from
Nov 4, 2024

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented Oct 28, 2024 •
edited
Loading

Pull request template

Adds the stats to the search store and implements the new BaseSlider component.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 requested a review from a team as a code owner October 28, 2024 09:55
@annacv
Copy link
Contributor

annacv commented Oct 31, 2024 •
edited
Loading

Hi, here some stuff I have seen:

  • XDS is a system based on multiples of 8, so I will suggest some changes on odd values 🙏
    Suggested changes tested:
    Captura de pantalla 2024-10-31 a les 12 06 22 p  m
  • I think there should be fewer characters when showing the range of max-value increase
  • Missing doc section & also inside the code itself.
  • Nice to have: some calc to be able to change the bar size and have the circles' position & the rest of the spacing recalculated
  • NIce to have: the max number getting moved along with the bar

Base automatically changed from feat/add-stats-to-adapter to main October 31, 2024 14:58
annacv
annacv approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@victorcg88 victorcg88 merged commit a3b1a0a into main Nov 4, 2024
4 checks passed
@victorcg88 victorcg88 deleted the feat/new-base-slider branch November 4, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annacv annacv annacv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorcg88 @annacv