Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design-system): facet alignment in firefox #1587

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Aug 6, 2024

Pull request template

Facets' icons are misaligned in Firefox.

Screenshot 2024-08-06 at 11 20 55

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4657

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Check the filters in the facets panel in the Firefox browser.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner August 6, 2024 12:20
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it seems both chrome and firefox are not aligned 😅 we need a better option

@lauramargar
Copy link
Contributor Author

lauramargar commented Aug 8, 2024

Now it seems both chrome and firefox are not aligned 😅 we need a better option

Hi @diegopf !!

If we change grid display to flex, it seems to work.

Screenshot 2024-08-08 at 09 43 02

Screenshot 2024-08-08 at 09 42 58

@annacv annacv requested a review from diegopf August 8, 2024 08:37
@diegopf diegopf merged commit 13b29d0 into main Aug 13, 2024
4 checks passed
@diegopf diegopf deleted the bugfix/EMP-4657-facets-icons-are-misaligned-in-firefox branch August 13, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants