fix(list-components): fix list components, migrate infinite-scroll directive and deprecated layouts #1576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 things done here:
NoElement
usage in-list
components (ResultsList
,PromotedsList
,BannersList
andNextQueriesList
). It fixes warnings regarding attrs inheritance to the root node.is the same as the following render function
UseLayouts
composable and refactor all deprecated layouts impliedHome
to use againMultiColumnMaxWidthLayout
InfiniteScroll
directive and make it simpler. Now, it doesn't depend on the component instance to emitUserReachedResultsListEnd
event soonInfiniteScrollEnd
function inResultsList
is no longer necessary.