Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): remove warnings first batch #1575

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented Jul 24, 2024

Motivation and context

This PR resolves several warnings when running the internal demo app:

  • Initial warning about overwriting the store modules.
  • Warnings about v-on="listeners" deprecation.
  • Removal of v-bind="attrs" and inheritAttrs=false, because Vue3 implemented by default the attributes inheritance.
  • Fixing warning on attrs inheritance in RenderlessFilter.
  • Fixing some components that throw warnings because the render function was incorrect.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 changed the title refactor(components): remove several warnings refactor(components): remove warnings first batch Jul 24, 2024
@victorcg88 victorcg88 marked this pull request as ready for review July 25, 2024 14:27
@victorcg88 victorcg88 requested a review from a team as a code owner July 25, 2024 14:27
Copy link
Member

@joseacabaneros joseacabaneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hundreds of warnings less! 🔝

@victorcg88 victorcg88 merged commit 1877da6 into vue3-update-rc Jul 26, 2024
0 of 2 checks passed
@victorcg88 victorcg88 deleted the remove-warnings branch July 26, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants