Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internal demo app functional #1574

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Make internal demo app functional #1574

merged 4 commits into from
Jul 24, 2024

Conversation

diegopf
Copy link
Contributor

@diegopf diegopf commented Jul 23, 2024 •
edited
Loading

Motivation and context

This PR makes just the necessary changes to make the internal demo app to be working again:

  • Refactors the home component to drop the MultiColumnMaxWidthLayout deprecated component.
  • Removes the animations until they are working with vue 3
  • BREAKING-CHANGE: refactors the GlobalXBus to use a prop to receive the listeners instead of relying on attributes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

@diegopf diegopf requested a review from a team as a code owner July 23, 2024 16:39
victorcg88
victorcg88 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@victorcg88 victorcg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected.

@diegopf diegopf merged commit a485dea into vue3-update-rc Jul 24, 2024
0 of 2 checks passed
@diegopf diegopf deleted the make-internal-demo-app-functional branch July 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorcg88 victorcg88 victorcg88 approved these changes

@joseacabaneros joseacabaneros joseacabaneros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegopf @joseacabaneros @victorcg88