refactor(no-element): towards getting rid of no-element component #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegopf
approved these changes
Jul 23, 2024
diegopf
requested changes
Jul 23, 2024
There was a problem hiding this comment.
We can remove the NoElement usage from the components and the import, right?
There was a problem hiding this comment.
Yes! I forgot it. Removed
joseacabaneros
force-pushed
the
towards-gettting-rid-of-no-element
branch
from
fe4f765 to
65baa0a
Compare
diegopf
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoElementcomponent is gonna be an issue in terms of attribute inheritance on Vue3 becauseFragmentcreation to support multiple root nodes. To solve it, there is a workaround we can achieve. This is to manage thevNodescreation in the render function in the components themselves (moreover, without generating breaking changes).To do it, we must refactor them in two steps:
propsin thehfunction, and they are breaking-change in the Vue migration (future PR once we have Vue3 officially)Components refactored in this PR to get rid of using
NoElementcomponent:DisplayResultProviderRenderlessExtraParamSelectedFiltersExtra:
ResultVariantsProvidercomponent was also refactored to avoid$scopedSlotswhich is breaking-change in Vue3.