feat: migrate internal view components #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauramargar
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Maybe you have forgotten to define the component name (name: 'AccessibilityCheck')
lauramargar
reviewed
Jul 11, 2024
| }, | ||
| props: { | ||
| result: { | ||
| type: Object as () => Result, |
There was a problem hiding this comment.
This prop type definition is ok, but you can also define the type with
Object as PropType<Result>
lauramargar
reviewed
Jul 11, 2024
| }, | ||
| props: { | ||
| suggestion: { | ||
| type: Object as () => NextQueryModel, |
There was a problem hiding this comment.
Here the same, you can also use
Object as PropType<NextQueryModel>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.