feat(display-emitter): support Vue3 to the component #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseacabaneros
commented
Jul 5, 2024
…display-emitter-vue3 # Conflicts: # packages/_vue3-migration-test/src/components/index.ts # packages/_vue3-migration-test/src/main.ts # packages/_vue3-migration-test/src/router.ts
diegopf
reviewed
Jul 10, 2024
| }); | ||
|
|
||
| onUnmounted(unwatchDisplay); | ||
| onUnmounted(() => { | ||
| unwatchDisplay(); |
There was a problem hiding this comment.
Suggested change
| unwatchDisplay(); | |
| unwatchDisplay && unwatchDisplay(); |
I guess this will not happen but there's a chance that unwatchDisplay is undefined now, so I think we should just check for it before invoking it
victorcg88
previously approved these changes
Jul 11, 2024
…display-emitter-vue3 # Conflicts: # packages/_vue3-migration-test/src/router.ts
diegopf
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Vue3 to the
DisplayEmittercomponent becuase the same issue we already saw with theMainScroll#1552.A template ref over a slot (AKA
NoElement) in vue3 renders aFragmentand the ref is lost, but in vue2 renders the firstvNodeof the slot and assign the ref in a right way.