Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build a Vue3 test search component #1540

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented Jun 27, 2024

Pull request template

Starting point to test the search experience with the migrated components in Vue3

Motivation and context

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@diegopf
Copy link
Contributor

diegopf commented Jul 1, 2024

LGTM overall

@victorcg88 victorcg88 force-pushed the feat/vue3-test-search-component branch from 3b234ff to c70e931 Compare July 1, 2024 10:23
@victorcg88 victorcg88 force-pushed the feat/vue3-test-search-component branch from c70e931 to 168e296 Compare July 1, 2024 11:01
@diegopf diegopf merged commit 0356202 into main Jul 1, 2024
4 checks passed
@diegopf diegopf deleted the feat/vue3-test-search-component branch July 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants