fix(vue3): fix minor Vue3 warnings about migration #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/EMP-4067-replace-disable-animation-mixin-by-use-disable-animation-composable
to
main
June 24, 2024 15:31
…r-vue3-warnings # Conflicts: # packages/_vue3-migration-test/src/components/animations/test-fade-and-slide.vue
lauramargar
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
:aria-*withtoString()to avoid attribute coercion https://v3-migration.vuejs.org/breaking-changes/attribute-coercion.html<template>for default slot definition because in Vue 3 will be treated as HTML native element.<template> tags with no special directives (v-if/else-if/else, v-for, or v-slot) are now treated as plain elements and will result in a native <template> element instead of rendering its inner content.::v-deepbecause it will be an issue in Vue 3, and we can live without them.Type of change